Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown Support #9

Merged
merged 4 commits into from Sep 22, 2021
Merged

Add Markdown Support #9

merged 4 commits into from Sep 22, 2021

Conversation

hlavu
Copy link

@hlavu hlavu commented Sep 21, 2021

Hi Quan, I have completed the code for the markdown support.
Here are some changes I had made:

  • In mini-ssg.js:

    • Modify the file handling so it will accept the ".md" extension.
  • In generateHTML.js:

    • Render Heading 1.
    • Render Heading 2.
    • Render Link.
  • In README.md:

    • Update README.md to add documentation for Markdown support.

Please review it and let me know If you want me to change any part.

Copy link
Owner

@mqnguyen5 mqnguyen5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the pull request looks great. However, there are some things that should be changed and I have left comments so you can have a look.

utils/generateHTML.js Outdated Show resolved Hide resolved
utils/generateHTML.js Outdated Show resolved Hide resolved
@hlavu
Copy link
Author

hlavu commented Sep 22, 2021

That's great, I will change them.

@hlavu hlavu closed this Sep 22, 2021
Copy link
Owner

@mqnguyen5 mqnguyen5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks for the contribution.

@mqnguyen5 mqnguyen5 reopened this Sep 22, 2021
@mqnguyen5 mqnguyen5 merged commit 17ef0f2 into mqnguyen5:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants