clarify mysql target documentation #335
Conversation
rgitzel
force-pushed
the
issue-334-clarify-mysql-target
branch
from
2291e17
to
e67855e
Compare
rgitzel
changed the title
rgitzel
changed the title
| - e.g. 'topic', 'payload' and '_dtiso' as above | ||
| - note that these all must be VARCHAR columns; timestamp columns are [not yet supported](https://github.com/jpmens/mqttwarn/issues/334#issuecomment-422141808) | ||
| - the 'fallback' column, as noted below | ||
| - #TODO: how is this different from 'payload'? |
There was a problem hiding this comment.
the fallback column gets all the JSON elements which have not been otherwise stored. e.g. if payload contains { name: Jane, number: 42 } (think JSON please), and we have a column name in the DB, then fallback will get {number: 42} whereas payload would have the full original payload.
There was a problem hiding this comment.
I just tried it, and it seems that 'payload' and 'full' are the same. I added the 'full' column and posted a new message:
+------+------------+-----------------------------------------------------+-----------------------------------------------------+-----------------------------+-------+
| id | name | payload | full | _dtiso | topic |
+------+------------+-----------------------------------------------------+-----------------------------------------------------+-----------------------------+-------+
| 90 | Jane Jolie | { "name" : "Jane Jolie", "id" : 90, "number" : 17 } | NULL | 2018-09-17T20:20:31.889002Z | db |
| 91 | Jane Jolie | { "name" : "Jane Jolie", "id" : 91, "number" : 17 } | { "name" : "Jane Jolie", "id" : 91, "number" : 17 } | 2018-09-18T20:44:51.662836Z | db |
Looking at the code, I see where the fallback column is set: https://github.com/jpmens/mqttwarn/blob/master/services/mysql.py#L67
But there's no point where fields are removed. We only know which fields should be removed after add_row is called, which is too late.
README.md
Outdated
|
|
||
| First it requires the [MySQLDb](http://mysql-python.sourceforge.net/) library to be installed. | ||
| - _Debian/Ubuntu_: `sudo apt-get install -y python-mysqldb` | ||
| - TODO: do we have any others? |
There was a problem hiding this comment.
@jpmens ?
This isn't the easiest library to install. :(
There was a problem hiding this comment.
That's not my fault ... :) I suggest leavig it, and/or saying "install with pip" in which case dependencies are automatically pulled in. Probably.
There was a problem hiding this comment.
I found a way to do it with pip so changed the instructions.
README.md
Outdated
|
|
||
| First it requires the [MySQLDb](http://mysql-python.sourceforge.net/) library to be installed. | ||
| - _Debian/Ubuntu_: `sudo apt-get install -y python-mysqldb` | ||
| - TODO: do we have any others? |
There was a problem hiding this comment.
That's not my fault ... :) I suggest leavig it, and/or saying "install with pip" in which case dependencies are automatically pulled in. Probably.
README.md
Outdated
| | 90 | Jane Jolie | { "name" : "Jane Jolie", "id" : 90, "number" : 17 } | 2018-09-17T20:20:31.889002Z | my/2 | | ||
| +------+------------+-----------------------------------------------------+-----------------------------+-------+ | ||
| ``` | ||
| Here, the plugin pulled values for the new columns from standard mqttwarn meta-data. |
There was a problem hiding this comment.
would you please s/meta-data/metadata/ ?
|
Thank you very much. Merged. |
jpmens
changed the title
https://github.com/rgitzel/mqttwarn/tree/issue-334-clarify-mysql-target#mysql