Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: websocket-streams to ws #1108

Merged
merged 3 commits into from Aug 7, 2020
Merged

feat: websocket-streams to ws #1108

merged 3 commits into from Aug 7, 2020

Conversation

YoDaMa
Copy link
Contributor

@YoDaMa YoDaMa commented May 29, 2020

No description provided.

@YoDaMa YoDaMa changed the title feat: websocket-streams to ws [!WIP!] feat: websocket-streams to ws May 29, 2020
@YoDaMa YoDaMa marked this pull request as draft August 3, 2020 17:57
@YoDaMa YoDaMa marked this pull request as ready for review August 6, 2020 06:03
@YoDaMa YoDaMa changed the title [!WIP!] feat: websocket-streams to ws feat: websocket-streams to ws Aug 6, 2020
@YoDaMa
Copy link
Contributor Author

YoDaMa commented Aug 7, 2020

the errors I'm seeing on Node version 10 are not consistent and are on functionality not related to streams, so I'm going to consider this passing. The flakiness of tests still needs to be improved...

@YoDaMa YoDaMa merged commit b2c1215 into mqttjs:master Aug 7, 2020
@fartagaintuxedo
Copy link

After this fix in v4.2 we are getting Uncaught (in promise) Error: ws does not work in the browser. Browser clients must use the native WebSocket object in all our applications.

@YoDaMa
Copy link
Contributor Author

YoDaMa commented Aug 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants