correct browser detection #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently webpack based projects couldn't import mqtt.js because incorrect browser detection. It's not a problem for react, where node-shims enabled, but a pain for angular (where enabling node-shims isn't supported officially) To fix that issue we need to check if `process` exists (it will be not available in browser) Also due to shims in webpack we need to check are we in process of bundling, or not.
|
@nosovk is this PR finished? |
|
yes, this one is done. Thanks |
ghost
mentioned this pull request
PremiumBurger
pushed a commit
to quickstar/MQTT.js
that referenced
this pull request
Nov 27, 2020
) currently webpack based projects couldn't import mqtt.js because incorrect browser detection. It's not a problem for react, where node-shims enabled, but a pain for angular (where enabling node-shims isn't supported officially) To fix that issue we need to check if `process` exists (it will be not available in browser) Also due to shims in webpack we need to check are we in process of bundling, or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently webpack based projects couldn't import mqtt.js because incorrect browser detection.
It's not a problem for react, where node-shims enabled, but a pain for angular (where enabling node-shims isn't supported officially)
To fix that issue we need to check if
processexists (it will be not available in browser)Also due to shims in webpack we need to check are we in process of bundling, or not.