fix(ws): add all parts of object to opts #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related #1193 |
ricardoffp
reviewed
Oct 29, 2020
| opts.hostname = parsed.hostname | ||
| opts.href = parsed.href | ||
| opts.origin = parsed.origin | ||
| opts.pathname = parsed.pathname |
There was a problem hiding this comment.
Hi 👋
I just upgraded the version of MQTT.js I'm using to the latest one (4.2.3).
Now I have an error while connecting because the path is not being included in the URL, even after this PR.
Did a few tests and added an extra opts.path = parsed.pathname and now the path is passed down and it connects. Can you take a look?
For example, an URL like: wss://example.server/mqtt would try to connect to wss://example.server.
Thank you!
added 2 commits
October 29, 2020 12:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to fix the regression published in v4.2.3