Add optional passphrase to TLS parameters, to allow for passphrase protected PEM files

[tobyjaffey]

No description provided.

[mcollina]

@adamvr How about moving to an option-object for this?
Example:

mqtt.createSecureServer({
  key: fs.readFileSync(keyPath),
  cert: fs.readFileSync(certPath),
  passphrase: passphrase
}, function() { .... });

We will have to support the previous syntax too, as I don't want to bump the minor version for this issue.

[tobyjaffey]

@adamvr @mcollina Long term, an option-object would be better, but, I guess it will break the API.
My change adds an optional parameter on the end, so should have no effect on existing code.

[mcollina]

I'm thinking about supporting the current API and the new one.
It is possible using this technique:

function createSecureServer(key, cert, callback) {
  var opts;

  if (typeof key === 'object') {
     opts = key;
     callback = cert;
  } else {
     opts = {
       key: fs.readFileSync(key),
       cert: fs.readFileSync(cert)
     }
  }

  //  continue as usual
}

Can you implement this and add one test for it?

Many thanks!

[adamvr]

👍 for an options object, so we can add more options later. I think the secureserver API wasn't very well thought out.

[mcollina]

@tobyjaffey would you like to updated this and refactor for supporting both the old and new API?

[tobyjaffey]

Sorry @mcollina, I'm not likely to get round to it for a while (until a customer shouts for it). Feel free to take over.