fix: fix regression from #1401 and allow CI test failures to break gitthub workflow #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eak github workflow
Codecov Report
@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage ? 86.21%
=======================================
Files ? 12
Lines ? 1306
Branches ? 0
=======================================
Hits ? 1126
Misses ? 180
Partials ? 0 Continue to review full report at Codecov.
|
vishnureddy17
previously approved these changes
Mar 14, 2022
lib/client.js
Outdated
| // there's no reason to change it and risk (another) regression. | ||
| // | ||
| // The only reason this code works is becaues code in MqttClient.publish, | ||
| // MqttClinet.subsribe, and MqttClient.unsubscribe ensures that we will |
There was a problem hiding this comment.
nit: typo
Suggested change
| // MqttClinet.subsribe, and MqttClient.unsubscribe ensures that we will | |
| // MqttClient.subscribe, and MqttClient.unsubscribe ensures that we will |
This was referenced Mar 14, 2022
|
Thank you very much! Any ETA when we can expoect a new release? |
|
ICYMI, it got released recently @Apollon77 |
|
Thank you for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.