Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connect method which accepts a URI see #164. #165

Merged
merged 4 commits into from
Mar 19, 2014

Conversation

wolfeidau
Copy link
Contributor

I have done my best to match the prevailing style while keeping the code fairly terse.

Looking forward to feedback as there are a few changes here.

Closes #164
Closes #131

@mcollina
Copy link
Member

Thanks!! Can you:

  • add some more detailed docs in the wiki
  • add support for the ?clientId= option in the parsing.

I'm not sure why a SSL test fails, but surely it's not your fault.

@wolfeidau
Copy link
Contributor Author

Yeah no problem will sort them out.

Cheers

@mcollina
Copy link
Member

Oh, I did not see you had updated the README in the commit. That was already fine!

@wolfeidau
Copy link
Contributor Author

I have updated it to support the clientId query param, added some information for the call to the API docs in the wiki and tweaked the README.md.

mcollina added a commit that referenced this pull request Mar 19, 2014
Added connect method which accepts a URI see #164.
@mcollina mcollina merged commit 5d04277 into mqttjs:master Mar 19, 2014
@mcollina
Copy link
Member

Thanks!! I hope to get this released soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URI connections Refactor createClient and createConnection to handle secure option
2 participants