Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit Keepalive timeout error and speed up tests using fake timers #1798

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Feb 26, 2024

This PR halves the time of tests 🎉

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.39%. Comparing base (e212fa7) to head (83a53f9).

❗ Current head 83a53f9 differs from pull request most recent head 4e8260e. Consider uploading reports for the commit 4e8260e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   79.59%   79.39%   -0.20%     
==========================================
  Files          24       24              
  Lines        1421     1422       +1     
  Branches      332      332              
==========================================
- Hits         1131     1129       -2     
- Misses        209      212       +3     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando robertsLando changed the title chore: speed up tests using fake timers feat: emit Keepalive timeout error and speed up tests using fake timers Feb 26, 2024
@robertsLando robertsLando merged commit 5d9bf10 into main Feb 26, 2024
6 checks passed
@robertsLando robertsLando deleted the flaky-tests branch February 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant