fix properties mqtt 5 in subscribe #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 94.41% 94.42% +0.01%
==========================================
Files 8 8
Lines 877 879 +2
Branches 232 233 +1
==========================================
+ Hits 828 830 +2
Misses 49 49
Continue to review full report at Codecov.
|
mcollina
reviewed
Oct 10, 2018
| @@ -374,7 +374,7 @@ Subscribe to a topic or topics | |||
|
|
|||
| * `topic` is a `String` topic to subscribe to or an `Array` of | |||
| topics to subscribe to. It can also be an object, it has as object | |||
| keys the topic name and as value the QoS, like `{'test1': 0, 'test2': 1}`. | |||
| keys the topic name and as value the QoS, like `{'test1': {qos: 0}, 'test2': {qos: 1}}`. | |||
There was a problem hiding this comment.
Is {'test1': 0, 'test2': 1} still supported?
There was a problem hiding this comment.
No, don’t supported from last PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed subscribe properties and docs for subscribe