Clear outgoing on close.
#951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `outgoing` was is cleared on close from the server, there is no chance to call callbacks in `outgoing`. `outgoing` entries exist invalidly after closing. That prevents `end` function. In the `end` function, if `force` is not set and `outgoing` exists, then wait `outgoingEmpty` event. However, the event never happen because previous entries are not removed. This update fixes the problem.
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
===========================================
- Coverage 93.66% 48.01% -45.66%
===========================================
Files 8 8
Lines 932 933 +1
Branches 243 243
===========================================
- Hits 873 448 -425
- Misses 59 485 +426
Continue to review full report at Codecov.
|
|
I forgot removing |
|
For qos1 and qos2 publish message, clearing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
outgoingwas is cleared on close from the server, there is nochance to call callbacks in
outgoing.outgoingentries existinvalidly after closing.
That prevents
endfunction. In theendfunction, ifforceis notset and
outgoingexists, then waitoutgoingEmptyevent. However,the event never happen because previous entries are not removed.
This update fixes the problem.