Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add on('connect') #963

Merged
merged 1 commit into from May 11, 2020
Merged

types: add on('connect') #963

merged 1 commit into from May 11, 2020

Conversation

taoqf
Copy link
Contributor

@taoqf taoqf commented Jun 15, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files           8        8           
  Lines         942      942           
  Branches      249      249           
=======================================
  Hits          883      883           
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9b8fb...21300f9. Read the comment docs.

@OmgImAlexis
Copy link
Contributor

@mcollina if this is correct can this please be merged?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 162d6aa into mqttjs:master May 11, 2020
PremiumBurger pushed a commit to quickstar/MQTT.js that referenced this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants