The protocols parameter of wx.connectSocket should be Array. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wechat mini app document url: https://developers.weixin.qq.com/miniprogram/dev/api/network/websocket/wx.connectSocket.html. If the protocols value is 'mqtt' instead of ['mqtt'], it will be failed if you use the android device, the interesting thing is iOS works. Both android and ios works if the value is an array.
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 8 8
Lines 942 942
Branches 249 249
=======================================
Hits 883 883
Misses 59 59Continue to review full report at Codecov.
|
MBerka
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
While not tested, all available documentation and examples of connectSocket() agree - should be Array.
https://developers.weixin.qq.com/miniprogram/en/dev/api/network/websocket/wx.connectSocket.html
|
@mcollina any chance this can be merged? |
PremiumBurger
pushed a commit
to quickstar/MQTT.js
that referenced
this pull request
Nov 27, 2020
) Wechat mini app document url: https://developers.weixin.qq.com/miniprogram/dev/api/network/websocket/wx.connectSocket.html. If the protocols value is 'mqtt' instead of ['mqtt'], it will be failed if you use the android device, the interesting thing is iOS works. Both android and ios works if the value is an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wechat mini app document url:
https://developers.weixin.qq.com/miniprogram/dev/api/network/websocket/wx.connectSocket.html.
If the protocols value is 'mqtt' instead of ['mqtt'], it will be failed if
you use the android device, the interesting thing is iOS works.
Both android and ios works if the value is an array.