Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

ignoredDependencies not working #111

Closed
mattiLeBlanc opened this issue Feb 4, 2016 · 3 comments
Closed

ignoredDependencies not working #111

mattiLeBlanc opened this issue Feb 4, 2016 · 3 comments

Comments

@mattiLeBlanc
Copy link

Hi,

I am using Angular and ui-router in my meteor project and I wanted to add 'angular-ui-router-anim-in-out' which doesn't have an meteor package yet.
So I thought to just use the bower package.

I follow instructions, add the bower.json to my /lib/bower folder (deepest folder).
also in the root of my meteor project I have added .bowerrc with the directory pointing to .meteor/local/bower.

So when I run meteor it installs the bower packages in /lib/bower/.meteor/local/bower.
Not really what I expected.

Then secondly...it is loading dependencies for angular-ui-router-anim-in-out whilst I have exluced them

{
  "name": "projectX",
  "authors": [
    ""
  ],
  "description": "",
  "moduleType": [],
  "license": "MIT",
  "homepage": "",
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "public/components/",
    "test",
    "tests"
  ],
  "dependencies": {
    "angular-ui-router-anim-in-out": "~1.0.2"
  },
  "ignoredDependencies": [
    "angular-animate",
    "angular",
    "angular-ui-router"
  ],
  "private": true
}

Any idea why this is?
Now the ignoredDependencies are loaded twice I reckon because I already have them as Meteor package.

@lorensr
Copy link
Collaborator

lorensr commented Feb 4, 2016

Hi! Try placing bower.json in project root. The ignored deps will be
downloaded to root/.meteor/local/bower, but they should not be sent to
the client.

On Wed, Feb 3, 2016 at 11:05 PM, Matti LeBlanc notifications@github.com
wrote:

Hi,

I am using Angular and ui-router in my meteor project and I wanted to add
'angular-ui-router-anim-in-out' which doesn't have an meteor package yet
So I thought to just use the bower package

I follow instructions, add the bowerjson to my /lib/bower folder (deepest
folder)
also in the root of my meteor project I have added bowerrc with the
directory pointing to meteor/local/bower

So when I run meteor it installs the bower packages in
/lib/bower/meteor/local/bower
Not really what I expected

Then secondlyit is loading dependencies for angular-ui-router-anim-in-out
whilst I have exluced them

{
"name": "projectX",
"authors": [
""
],
"description": "",
"moduleType": [],
"license": "MIT",
"homepage": "",
"ignore": [
"*/",
"node_modules",
"bower_components",
"public/components/",
"test",
"tests"
],
"dependencies": {
"angular-ui-router-anim-in-out": "~102"
},
"ignoredDependencies": [
"angular-animate",
"angular",
"angular-ui-router"
],
"private": true
}

Any idea why this is?
Now the ignoredDependencies are loaded twice I reckon because I already
have them as Meteor package


Reply to this email directly or view it on GitHub
#111.

@mattiLeBlanc
Copy link
Author

Yup, that worked. So the docs suggesting to put your bower.json as deep as possible isn't valid advice anymore, I reckon?
Thanks for the quick suggestion buddy.

@lorensr lorensr closed this as completed in f738dfa Feb 4, 2016
@lorensr
Copy link
Collaborator

lorensr commented Feb 4, 2016

Thanks, forgot about that. If you'd like to nest, place the .bowerrc in the same directory and use a relative path: f738dfa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants