Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Error when specifying a commit hash as the version #24

Closed
speigg opened this issue Jul 17, 2014 · 3 comments
Closed

Error when specifying a commit hash as the version #24

speigg opened this issue Jul 17, 2014 · 3 comments

Comments

@speigg
Copy link
Contributor

speigg commented Jul 17, 2014

  "bower": {
    "famous": {
      "git": "https://github.com/Famous/famous",
      "version": "98e05eb4326f099e"
    }
  }
While building the application:
/Users/gspeiginer/.meteor/tools/858c88b520/lib/node_modules/fibers/future.js:326:15: Unable to find suitable version for famous (compiling smart.json)
  at Object.Future.wait (/Users/gspeiginer/.meteor/tools/858c88b520/lib/node_modules/fibers/future.js:326:15)
  at Object.install (packages/meteor/helpers.js:111)
  at bowerHandler (packages/bower/plugin/handler.js:58)
  at packages/bower/plugin/handler.js:168
@speigg
Copy link
Contributor Author

speigg commented Jul 17, 2014

I finally got this to work. Two things:

  1. "git" was supposed to be "source" (my fault)
  2. For some reason, I couldn't use the name "famous", because it was ignoring all my options.

This is what finally worked:

  "bower": {
    "famousX": {
      "source": "git://github.com/Famous/famous.git",
      "version": "98e05eb4326f099",
      "additionalFiles": [
        "dist/famous.min.js"
      ]
    }
  }

I feel like it should also work without me having to add the X at the end.

@speigg
Copy link
Contributor Author

speigg commented Jul 17, 2014

Okay, never mind, the reason it didn't work until I added the X was because it was previously grabbing from the existing cache (and thus ignoring all of the options I specified)... problem solved.

@speigg speigg closed this as completed Jul 17, 2014
@mquandalle
Copy link
Owner

The current code is a bit tricky. I have great hopes that the upcoming packaging system in Meteor will allow us to create a much more better, finely integrated bower package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants