Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Overrides support #54

Merged
merged 1 commit into from
Feb 16, 2015
Merged

Overrides support #54

merged 1 commit into from
Feb 16, 2015

Conversation

steve8708
Copy link
Contributor

Some packages don't use the main property, so similar projects (e.g. wiredep) allow an "overrides" property to override such as -

Unless there is another way to do this that I am not aware :)

Open to feedback on if there is any other way you'd prefer this implemented

Happy Valentines day

{
  "name": "Chat",
  "dependencies": {
    "jquery": "~2.1.3",
    "lodash": "~3.1.0",
    "modernizr": "~2.8.3",
    "angularjs-toaster": "~0.4.10",
    "angular-hotkeys": "chieffancypants/angular-hotkeys#~1.4.5",
    "underscore.string": "~3.0.3",
    "ace-builds": "~1.1.8",
    "angular-ui-ace": "~0.2.3"
  },
  "overrides": {
    "ace-builds": {
      "main": [
        "src-noconflict/ace.js",
        "src-noconflict/mode-coffee.js",
        "src-noconflict/theme-tomorrow_night_eighties.js"
      ]
    }
  }
}

@lorensr
Copy link
Collaborator

lorensr commented Feb 16, 2015

Hi Steve, happy belated valentine's day! Thanks for the PR, definitely think it's a good feature. Testing your code, when I add a not-previously-installed package to bower.json (with no overrides) and run meteor, I get this:

=> Started MongoDB.                           
=> Errors prevented startup:                  

   While building the application:
   fs.js:438:18: ENOENT, no such file or directory '.meteor/local/bower/ace-builds/.bower.json' (compiling bower.json)
   at Object.fs.openSync (fs.js:438:18)
   at Object.fs.readFileSync (fs.js:289:15)
   at packages/bower/plugin/handler.js:70:1
   at Function._.each._.forEach (packages/underscore/underscore.js:113:1)
   at bowerHandler (packages/bower/plugin/handler.js:68:1)
   at Package (packages/bower/plugin/handler.js:184:1)

whereas I should get this:

=> Started MongoDB.                           
Bower:  ace-builds v1.1.8 successfully installed

@lorensr
Copy link
Collaborator

lorensr commented Feb 16, 2015

Ack! I'm sorry, my bad – I made a typo. Retesting.

@lorensr
Copy link
Collaborator

lorensr commented Feb 16, 2015

Works!

lorensr added a commit that referenced this pull request Feb 16, 2015
@lorensr lorensr merged commit e6512e0 into mquandalle:master Feb 16, 2015
@steve8708
Copy link
Contributor Author

Woo! Thanks :)

Love this package

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants