po4a-0.59 breaks build of schroot-1.6.10 on Fedora

[sergiomb2]

Hi,
I tested build po4a-0.58.1 and schroot-1.6.10 builds fine but starting in po4a-0.59 the build fails , any clue ?

Thank you

Missing argument in sprintf at /usr/share/perl5/vendor_perl/Locale/Po4a/Common.pm line 179, <CONFIG> line 1.
/builddir/build/BUILD/schroot-1.6.10/man/po4a.cfg:1: (too many POT files: 'po//schroot-man.pot' and ''.)
po//schroot.pot

CMake Error at man/CMakeLists.txt:77 (add_custom_command):
  add_custom_command Wrong syntax.  A TARGET or OUTPUT must be specified.


-- Configuring incomplete, errors occurred!
See also "/builddir/build/BUILD/schroot-1.6.10/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log".
See also "/builddir/build/BUILD/schroot-1.6.10/x86_64-redhat-linux-gnu/CMakeFiles/CMakeError.log".

with lots of new warning messages ike:

po4a::man: This page includes another file with '.so'. Do not forget to translate this file ('config.man').
po4a::man: This page includes another file with '.so'. Do not forget to translate this file ('authors.man').
po4a::man: This page includes another file with '.so'. Do not forget to translate this file ('copyright.man').

https://koji.fedoraproject.org/koji/taskinfo?taskID=48681535
https://kojipkgs.fedoraproject.org//work/tasks/1623/48681623/build.log

[mquinson]

Hello, thanks for the report, and for the pinpointing of the version inducing the problem, that was helpful.

You can safely ignore the warnings, they are unrelated. One should just make sure that the other files are actually translated, but there is no connection with your issue.

I took the time to investigate the issue using the debian package as this is the one I have at hand. I hope that the fix I'm coming up with will be sufficient.

The bad news is that my fix requires some change to both po4a and schroot. First, schroot needs to use the correct path to its config files:

--- schroot-1.6.10.orig/man/po4a.cfg
+++ schroot-1.6.10/man/po4a.cfg
@@ -1,4 +1,4 @@
-[po_directory] po/
+[po_directory] man/po

 [po4a_alias:man] man opt:"-M UTF-8 -L UTF-8"

Then, it requires a patch to po4a itself to ignore the PO files found twice during the config phase. I will release a new version of po4a with this change once I cleaned up my patch. Please keep tuned up :)

[mquinson]

@sergiomb2 could you please confirm that with both the git version of po4a and the patch to man/po4a.cfg that I posted earlier, the schroot builds fine for you?

[mquinson]

If you have difficulties running the tests with the git version of po4a, it should be sufficient to apply this patch to the po4a binary in your /usr/bin directory. The other changes in the git compared to the last release are only related to the translations and could be ignored.

[sergiomb2]

Hello, thanks for the report, and for the pinpointing of the version inducing the problem, that was helpful.

You can safely ignore the warnings, they are unrelated. One should just make sure that the other files are actually translated, but there is no connection with your issue.

I took the time to investigate the issue using the debian package as this is the one I have at hand. I hope that the fix I'm coming up with will be sufficient.

The bad news is that my fix requires some change to both po4a and schroot. First, schroot needs to use the correct path to its config files:

--- schroot-1.6.10.orig/man/po4a.cfg
+++ schroot-1.6.10/man/po4a.cfg
@@ -1,4 +1,4 @@
-[po_directory] po/
+[po_directory] man/po

 [po4a_alias:man] man opt:"-M UTF-8 -L UTF-8"

Then, it requires a patch to po4a itself to ignore the PO files found twice during the config phase. I will release a new version of po4a with this change once I cleaned up my patch. Please keep tuned up :)

yes it fixes the build

[sergiomb2]

If you have difficulties running the tests with the git version of po4a, it should be sufficient to apply this patch to the po4a binary in your /usr/bin directory. The other changes in the git compared to the last release are only related to the translations and could be ignored.

I just use released versions, I tested with po4a-0.59 and with the latest version po4a-0.60

Thank you

[mquinson]

Now the latest version is v0.61 :)
I'm closing this issue now that it seems resolved. Feel free to reopen if the problem persists.

Thanks again for reporting,

[sergiomb2]

Thank you for your quick response.

[sergiomb2]

--- schroot-1.6.10.orig/man/po4a.cfg
+++ schroot-1.6.10/man/po4a.cfg
@@ -1,4 +1,4 @@
-[po_directory] po/
+[po_directory] man/po

 [po4a_alias:man] man opt:"-M UTF-8 -L UTF-8"

BTW , I still need this patch to build schroot-1.6.10 with po4a >= 0.59, I tested with all versions 0.60 , 0.61, 0.62 and 0.63 in all versions I still need this patch .

Best regards,

[mquinson]

Hello, I thought that this could stay this way. Does it induce any difficulty?

[sergiomb2]

ah, OK , no any difficulty, I thought you said that we won't need the patch, so everything is fine