[nomerge] enhance debug output, fix docbook behavior, allow separate input for POT #148
Conversation
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Matching for addendum is not always against "line". <title> is separate data string for DocBook XML which should be more likely than SGML Signed-off-by: Osamu Aoki <osamu@debian.org>
The $VERSION variable is the version of the whole PO4A software, there is no point to change it here.
Signed-off-by: Osamu Aoki <osamu@debian.org>
Add new section OVERRIDE THE DEFAULT BEHAVIOR WITH COMMAND LINE OPTIONS with example. Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
|
Could you consider adding the tests to the pull request directly, please? Thx |
* One line code addition to normalize array items
Split array item on each internal "\n" while keeping it with the lookbehind
trick.
This doesn't cause problem for man page handling and allow us not keep original
default values for Docbook module.
* Documentation updates and correction
For $self->{TT}{doc_in}=() "[2] the type" is incorrect
Signed-off-by: Osamu Aoki <osamu@debian.org>
This reverts commit 6e4e875.
This reverts commit b8fb1f7.
Signed-off-by: Osamu Aoki <osamu@debian.org>
TODO: add test cases
|
Changing tag type is certainly a workaround. But I think that is not the safest and robust way to address addendum problem. Give me some time to learn test code writing ... No need to merge yet |
mquinson
changed the title
|
Hello @osamuaoki , please take your time, your work is really welcome. |
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Perl's one dimensional array creates big barrier for non-perl users to read code. Signed-off-by: Osamu Aoki <osamu@debian.org>
tags in untranslated tag list don't take W nor w translation option since these are only valid for translated tags Signed-off-by: Osamu Aoki <osamu@debian.org>
* Docbook article.xml example * Japanese PO handling * Addendum into articleinfo * Docbook book.xml example * Japanese PO handling * Addendum into bookinfo * comment in translated paragraph * option to change tag property * Docbook book-auto.xml example * Support of pot_in:<filepath_to_master.xml_for_POT> * Verify static PO for auto content addition to master.xml_for_output Signed-off-by: Osamu Aoki <osamu@debian.org>
|
Hi, I finally got test case for DocBook added. @{$self->{TT}{doc_out}} = map { split /(?<=\n)/, $_ } @{$self->{TT}{doc_out}}; Although, tweaking tag behavior solved issue for my upload of Debian History, this is not the approach we want to use for releasing po4a since it may cause other regression. So I decided Document work around in manpage. Also, tracing code was not easy since debug output was not organized. I have added extensive debug output for easier future debug.
|
|
I think code is practically ready to be merged. One thing you may want to check is I left generated file in the t/t-02-addendums directory for easy review. But if you want cleaner build tree, move them to tmp/. That's all. |
|
I cleaned up history for easier review. (i know its bad idea usually but ... it was ugly) |
Sorry for my old patch containing version.
Here is my tentative work to address several issues. docbook behavior change is based on tarball test posted to #76 .
These are important to allow translator data addition.
With this debug outputs, we see what are we matching against for addendum. Also actual tag property setting can be seen.
I cherry picked new changes in master so it is cleanly merged.
TODO: