Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoc: Don't split in attributes include:: and ifeval:: lines #298

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

dbaio
Copy link
Contributor

@dbaio dbaio commented Mar 13, 2021

Issue summary:

    # | -ifeval::["{foo}" == "bar"]
    # | -include::{foo-path}bar.adoc[leveloffset=+1, lines=7..21;32..-1]
    # | +ifeval::["{foo}",  == "bar"]
    # | +include::{foo-path}bar.adoc[leveloffset=+1,,  lines=7..21;32..-1]
    # |  endif::[]

More details in the maillist post.

First PR here, I'll need someone to review please.

Thanks!

@mquinson
Copy link
Owner

Hello Danilo,

I did check your changes, and they look very good, many thanks! The only nitpicking remark could be that the the test could have been placed in another test. But I agree that what you needed to add was so small that it didn't really deserve a separate test.

Thanks for this contribution, and welcome onboard ;)
Mt

@mquinson mquinson merged commit f931cd0 into mquinson:master Mar 13, 2021
@dbaio
Copy link
Contributor Author

dbaio commented Mar 13, 2021

@mquinson thanks for the feedback and quick reviewing.
Noted that for a future PR.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Mar 14, 2021
Don't split in attributes include:: and ifeval:: lines.

This fix an issue in the new FreeBSD translation workflow.

Obtained from:	mquinson/po4a#298


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@568387 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Mar 14, 2021
Don't split in attributes include:: and ifeval:: lines.

This fix an issue in the new FreeBSD translation workflow.

Obtained from:	mquinson/po4a#298
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Mar 15, 2021
Don't split in attributes include:: and ifeval:: lines.

This fix an issue in the new FreeBSD translation workflow.

Obtained from:	mquinson/po4a#298


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@568387 35697150-7ecd-e111-bb59-0022644237b5
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
Don't split in attributes include:: and ifeval:: lines.

This fix an issue in the new FreeBSD translation workflow.

Obtained from:	mquinson/po4a#298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants