Feat: refactore extend expression #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1956 1964 +8
=========================================
+ Hits 1956 1964 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
💾 Refactored⚠️ this PR is solved this to bring things in the same logic categories, and now SemanticContext for stack instructions is fully flexible for
Extend Expressionwith improved instructions generation results.Rethinking design for
ExtendExpressionAST, andSemanticContextinstructions for extended expressions. Previously it was different logic categories. And it was pitfalls, as it was practically difficult to generate efficient Instructions forSemanticContextrelated on AST.ExtendedExpressionAST.➡️ Added tests for
extended expressionsandSemanticStackContext instructionsfor it➡️ Extended (README)[README.md] documentation
➡️ Refactored AST to add generic type for
ExtendedExpressioninstructions➡️ Extended clippy to new Rust requirements