Upgrade pipeRunner typing

[mrWh1te]

Botmation/src/botmation/actions/assembly-lines.ts

Line 300 in 63ccfb0

pipeObject = wrapValueInPipe(nextPipeValueOrUndefined as PipeValue|undefined)

Remove as PipeValue|undefined, perhaps through a generic, the function can have a type state for the pipe object/value that can be organically updated with each resolved BotAction.

This may end up making a major change where the Pipe object is put at the start of the injects to preserve type in array destructuring. That effects everything in Botmation.

Originally, the pipe object was put at the end of the injects array to make the expected injects order the same between chain and pipe, with no dev effort. So a BotAction that expects inject1, inject2, inject3 will get the same injects whether or not its ran inside a chain or pipe (if injected the same injects).

Putting the pipe object at the start of the injects array will set all the expected injects index off by 1. It creates a problem for dev's making BotAction's that use injects, in terms of chain and pipe compatibility

To get around this, Botmation can have a new standard helper function to get the pipe object/value and injects in the same "chain" like order. The downside, it would put a new requirement on dev's creating BotAction's that use injects, to always use this function.

Need time to think about this. Maybe this is a good time to explore "hooks" in some kind of way? Doesn't have to be programmed the same way as in React, but has a familiar syntax that may work here i.e. getInjects(), getPipeValue()

The goal is for all assemblers that carry a value such as Pipe and SwitchPipe will be upgraded with similar typing functionality, once this simpler function is upgraded

[mrWh1te]

exploration - hooks

could replace injects as param in BotAction to a custom hook?

could do the same with page ?

what if the only param a BotAction had was pipeValue?: PipeValue ?

how do hooks effect testing strategy?

add & set inject BotAction's

• ability to append an inject to the array of injects destructured via hook
• ability to set a key->value i.e. user->userInject to be specifically objected via hook
• concern: A botaction would then require another botaction to run prior, for injects setup in order for the hooks to work

[mrWh1te]

what if injects were an object, with methods, like a Map

But, in addition, have some kind of array for dev's who have no need for keys when accessing using injects

[mrWh1te]

what if everything passed into a BotAction (pipe object & injects) were wrapped in a single object?

This object could support both key'ed injects and anon injects

then the difference between chain and pipe parameterization is negligible