Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRIconView shapeLayer animation and appearance selectors. #87

Closed
wants to merge 5 commits into from

Conversation

boherna
Copy link

@boherna boherna commented Dec 27, 2014

Allows the shapeLayer of MRIconView to be animated. Adds the appearance selectors to MRIconView for setting the border and line widths, and also the animation duration.

…ce selectors to MRIconView for setting the border and line widths, and also the animation duration.
@mrackwitz
Copy link
Owner

So much great stuff in one single commit! 🎉
Didn't want to leave you alone without feedback: so would you mind to integrate your proposed changes a slight bit more into the existing code base by changing indentation from tabs to whitespaces and perhaps reverting the removal of the newlines in the public interface?
Otherwise I love the idea to have animated transitions for the overlay by implementing the animation pseudo-protocol. I guess, that's what you use it for, right? I would love to make that a bit more obvious by exposing the implemented selectors startAnimating, stopAnimating, … in the public interface with some little words of documentation, which could be basically just copied over from MRActivityIndicatorView.

… view and the maximum height to use when laying out the title label.
* upstream/master:
  Using provided height for custom view mode.
  [Lockfile] pod update MRProgress MRProgress/AFNetworking
  [Podspec] Bump version 0.8.2
  [CocoaPods] pod update
  [Podspec] Lock minor level of dependency to AFNetworking
  [CocoaPods] pod update
  [CocoaPods] Add Pods directory
  [Project] Add -Wno-cstring-format-directive to WARNING_CFLAGS
  Update MRProgress.podspec
  When using Xcode 6.3 MRNavigationBarProgressView.h, MRCircularProgressView.h generates a compiler warning as follows:
  Add support for  borderWidth & lineWidth properties to MRIconView

Conflicts:
	src/Components/MRIconView.m
@boherna boherna closed this Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants