Skip to content
This repository has been archived by the owner on Jun 5, 2018. It is now read-only.

app-misc/haguichi ebuild improvements #5

Merged
merged 1 commit into from Mar 30, 2016
Merged

app-misc/haguichi ebuild improvements #5

merged 1 commit into from Mar 30, 2016

Conversation

Pinkbyte
Copy link

Fix sandbox violations, rework whole ebuild to use cmake-utils and vala eclasses

@mradermaxlol
Copy link
Owner

@Pinkbyte isn't it better to use
export VALAC="$(type -p valac-$(vala_best_api_version))" ?

@Pinkbyte
Copy link
Author

If you look into vala.eclass, you will see, that VALAC environment variable is already exported in vala_src_prepare

Unfortunately FindVala.cmake in this package completely ignores it. If you can patch buildsystem to make it consider this variable - feel free to do so ;-)

@mradermaxlol
Copy link
Owner

@Pinkbyte hmm, that's damn bad. I'll take a look at Budgie/other Vala projects' configs and will try to commit changes upstream ;)

I'm then accepting the PR, thanks a lot! Gotta update the ebuilds to EAPI 6 now :)

@mradermaxlol mradermaxlol merged commit d2bd777 into mradermaxlol:master Mar 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants