Move entity classes to EF-Independent project #17
Conversation
|
@mrahhal If you are OK with the PR, could you please upload the Model nuget package so that we can reference it in our projects? |
There was a problem hiding this comment.
Sounds like a good idea.
In addition to the review comments I added that require changes, could you also rename the project from "Model" to "Models"? I'd like to follow this convention. (Make sure the folder's name is renamed too).
After those changes, I'll start releasing this as a package.
| <PropertyGroup> | ||
| <TargetFramework>netstandard1.3</TargetFramework> | ||
| <GeneratePackageOnBuild>false</GeneratePackageOnBuild> | ||
| <Version>3.0.4</Version> |
There was a problem hiding this comment.
There is a common.props file that I import in all csprojs that let me share lots of those values, and also reference a single version. So please check the other csprojs on how to edit this one to take advantage of common.props. You'll still need to add the TargetFramework element above to override that.
build.cake
Outdated
| DeleteDirectory("./artifacts", new DeleteDirectorySettings { | ||
| Recursive = true, | ||
| Force = true | ||
| }); |
There was a problem hiding this comment.
Some indentation on the last 3 lines here please. And remove the line trailing line after this.
|
I've made some changes based on your requests. Could you please check? |
| @@ -1,16 +1,15 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <Import Project="../../build/version.props" /> | |||
There was a problem hiding this comment.
"common.props" please! It includes "version.props" and adds stuff like "PackageLicenseUrl" and the like.
|
Fixing an issue with netstandard tfm usage. Package "MR.AspNet.Identity.EntityFramework6.Models" should be ready by today. |
|
I didn't have time to fix those today. I see you've already merged it. Thanks! |
|
Released as |
I've moved the entity classes to a separate project so that people can reference them in their model or domain projects without any requirement to reference EntityFramework. This way one can use the same model in the future with EF Core.