New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade JHipster monolith to Spring Security 5.1 OIDC Support #1
Open
mraible
wants to merge
18
commits into
master
Choose a base branch
from
spring-security-5.1
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e5ee242
Upgrade to Spring Security 5.1 OIDC Support
a0e27c1
Use /api/login to trigger authentication
2623beb
Fixed authorities mapping
dc12aaa
Initial application generated by JHipster-5.8.2
1ad0823
Initial application generated by JHipster-5.8.2
891667d
Initial application generated by JHipster-5.8.2
9ca2dc7
Initial application generated by JHipster-5.8.2
a12a5a6
Initial application generated by JHipster-5.8.2
ffe3d5b
Initial application generated by JHipster-5.8.2
d12dd9b
Initial application generated by JHipster-5.8.2
098b1ce
Initial application generated by JHipster-5.8.2
6cf3b22
Initial application generated by JHipster-5.8.2
6baf785
Initial application generated by JHipster-5.8.2
e5055a8
Initial application generated by JHipster-5.8.2
cfa743d
Initial application generated by JHipster-5.8.2
cd0323d
Initial application generated by JHipster-5.8.2
75bfa6f
Add attempt at LogoutResourceIT
0738ada
Fix test
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 0 additions & 101 deletions
101
src/main/java/com/mycompany/myapp/config/OAuth2Configuration.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mraible,
Thanks for giving this example, I love looking at your work as a point of reference.
Question for you around converting the groups claim to the authorities in the security context. Any reason for not just using a custom mapper in keycloak to map the groups/client-roles/realm-roles to a claim labelled as one of the
WELL_KNOWN_SCOPE_ATTRIBUTE_NAMES
[1] and letting spring do its conversion?[1] https://github.com/spring-projects/spring-security/blob/master/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtGrantedAuthoritiesConverter.java#L40