-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO_ENABLE_CORS operator #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -113,6 +113,7 @@ If you created users on the MySQL version 8 server before enabling the `mysql_na | |||
endif::PAM[] | |||
. Optionally, depending on your needs, set environment variables. To set an environment variable, click *Add new Environment variable*, then enter the name and value for the variable in the *Name* and *Value* fields. | |||
** If you want to configure your {KIE_SERVER} deployment to use Prometheus to collect and store metrics, set the `PROMETHEUS_SERVER_EXT_DISABLED` environment variable to `false`. For instructions about configuring Prometheus metrics collection, see {URL_MANAGING_SETTINGS}#prometheus-monitoring-ocp-proc_execution-server[_{MANAGING_KIE_SERVER}_]. | |||
** If you are using {RH-SSO} authentication and your {RH-SSO} environment requires CORS support, set the `SSO_ENABLE_CORS` variable to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion of documentation update to be more specific (Inspired by SSO documentation )
** If you are using {RH-SSO} authentication and your {RH-SSO} environment requires CORS support, set the `SSO_ENABLE_CORS` variable to `true`. | |
** If you are using {RH-SSO} authentication and by your application is required Cross-Origin Resource Sharing enabled for {KIE_SERVER} deployment, add environment variable named `SSO_ENABLE_CORS` to {KIE_SERVER} object and set value to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jakubschwan
@ramendik do you mind to apply his suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spolti I am honesly lost here: so this is an application requirement? Not an SSO requirement? But it is somehow different for SSO than for other CORS use cases, and will still work without enabling CORS support on the KIE server?
Also this is only for the KIE server and not Business Central?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mramendi it also applies to business central, the sso section is shared for both components, right?
@ramendik I see your point, @jakubschwan maybe we also need to make user know that SSO must have cors enabled as well, or it is enabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have scheduled a meeting as I think we have some misunderstanding somewhere
* SSO_ENABLE_CORS operator * CLarification after discussion
* SSO_ENABLE_CORS operator * CLarification after discussion
* SSO_ENABLE_CORS operator * CLarification after discussion
* SSO_ENABLE_CORS operator * CLarification after discussion
* SSO_ENABLE_CORS operator * CLarification after discussion
* SSO_ENABLE_CORS operator * CLarification after discussion
No description provided.