Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on client.quit() after client.unsubscribe() #87

Closed
cloudhead opened this issue Apr 14, 2011 · 1 comment
Closed

Error on client.quit() after client.unsubscribe() #87

cloudhead opened this issue Apr 14, 2011 · 1 comment
Labels

Comments

@cloudhead
Copy link

As discussed on IRC, when doing something like:

client.unsubscribe();
client.quit();

The client raises an exception:

Error: subscriptions are active but got an invalid reply: OK
    at RedisClient.return_reply (/usr/local/lib/node_modules/redis/index.js:417:19)
    at RedisReplyParser. (/usr/local/lib/node_modules/redis/index.js:87:14)
    at RedisReplyParser.emit (events.js:64:17)
    at RedisReplyParser.send_reply (/usr/local/lib/node_modules/redis/lib/parser/javascript.js:266:18)
    at RedisReplyParser.execute (/usr/local/lib/node_modules/redis/lib/parser/javascript.js:120:22)
    at RedisClient.on_data (/usr/local/lib/node_modules/redis/index.js:328:27)
    at Socket. (/usr/local/lib/node_modules/redis/index.js:99:14)
    at Socket.emit (events.js:64:17)
    at Socket._onReadable (net.js:672:14)
    at IOWatcher.onReadable [as callback] (net.js:177:10)

Removing the call to quit fixes this, but I don't know if it destroys the socket.

mranney added a commit that referenced this issue Apr 22, 2011
*  connection error did not properly trigger reconnection logic [GH-85]
*  client.hmget(key, [val1, val2]) was not expanding properly [GH-66]
*  client.quit() while in pub/sub mode would throw an error [GH-87]
*  client.multi(['hmset', 'key', {foo: 'bar'}]) fails [GH-92]
@mranney
Copy link
Contributor

mranney commented Apr 22, 2011

I believe this is fixed just now in v0.0.6, can you please try it out and let me know?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants