Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection issues in 0.11.0 release #639

Closed
wants to merge 2 commits into from
Closed

Conversation

maeldur
Copy link

@maeldur maeldur commented Aug 1, 2014

Trying to address issue #632, I believe this commit 9c68a28 broke the ability to connect to a redis instance listening on a unix socket in this fashion:

var redis = require("redis"),
     redisClient = redis.createClient("/tmp/redisTest.sock");

as well as being able to connect to redis when passing in the cnxOptions directly as:

var config = {
   port: 6379, 
   host: '127.0.0.1',
   options: {}
};

var redis = require("redis"),
     redisClient = redis.createClient(config);

my pull request attempts to check if you are sending a unix path or connection options in port_arg and set the cnxOptions correctly to net.createConnection

this should fix some, if not all of the connection regressions described in #632

@brycebaril
Copy link
Contributor

Thanks for the submission -- went with PR #642 which had a more complete implementation. It's pushed as 0.12.0

@brycebaril brycebaril closed this Aug 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants