Fix connection issues in 0.11.0 release #639
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address issue #632, I believe this commit 9c68a28 broke the ability to connect to a redis instance listening on a unix socket in this fashion:
as well as being able to connect to redis when passing in the cnxOptions directly as:
my pull request attempts to check if you are sending a unix path or connection options in port_arg and set the cnxOptions correctly to net.createConnection
this should fix some, if not all of the connection regressions described in #632