Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEF_RUN_DIR uses localstatedir instead of runstatedir #293

Open
fmarier opened this issue Feb 25, 2019 · 2 comments
Open

DEF_RUN_DIR uses localstatedir instead of runstatedir #293

fmarier opened this issue Feb 25, 2019 · 2 comments
Assignees

Comments

@fmarier
Copy link
Contributor

fmarier commented Feb 25, 2019

DEF_RUN_DIR is defined based on SYSRUNDIR which is itself set to localstatedir.

In the Debian package, I've set this to /run but it does look strange to set --localstatedir when there is also a --runstatedir configure variable:

--localstatedir=DIR     modifiable single-machine data [PREFIX/var]
--runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]

It doesn't look like runstatedir is used anywhere and so it doesn't matter that it ends up being set to a non-sensical value (/run/run), but perhaps DEF_RUN_DIR should use that instead of localstatedir?

@mrash
Copy link
Owner

mrash commented Mar 13, 2019

Hi - can you send a pull request for this one? Not sure if I have it correct. I'm assuming server/fwknopd_common.h needs to be modified at line 72.

@mrash mrash self-assigned this Mar 13, 2019
fmarier added a commit to fmarier/fwknop that referenced this issue Jul 6, 2019
@fmarier
Copy link
Contributor Author

fmarier commented Jul 6, 2019

I've just created #300 and tested it in the Debian package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants