Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace all SomeReal by SomeFloat #256

Closed
wants to merge 1 commit into from
Closed

replace all SomeReal by SomeFloat #256

wants to merge 1 commit into from

Conversation

Vindaar
Copy link
Collaborator

@Vindaar Vindaar commented Jul 7, 2018

Replaces all occurrences of SomeReal by SomeFloat, because for some reason SomeReal now throws an undeclared identifier error.

@mratsim
Copy link
Owner

mratsim commented Jul 7, 2018 •
edited

SomeFloat doesn't exist on the latest stable unfortunately. There are 2 solutions:

  • Fix Nim
  • Add a ArraymancerFloat alias maps to SomeReal on 0.18 and SomeFloat on devel, or just = float32 or float64.

I think Nim should be fixed here.

@mratsim
Copy link
Owner

mratsim commented Jul 7, 2018

upstreamed: nim-lang/Nim#8239

@Vindaar
Copy link
Collaborator Author

Vindaar commented Jul 7, 2018

If that PR isn't merged, I'll add an alias for 0.18 to this PR.

@mratsim
Copy link
Owner

mratsim commented Jul 7, 2018

Merged upstream.

@mratsim mratsim closed this Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need upstream fix regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vindaar @mratsim