Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place division/multiplication by scalar, closes #20 #40

Merged
merged 1 commit into from Sep 16, 2017

Conversation

edubart
Copy link
Contributor

@edubart edubart commented Sep 14, 2017

This also introduces the fmap_inplace function which is used to implement those operations.

@mratsim
Copy link
Owner

mratsim commented Sep 14, 2017

For the inplace map/fmap I was thinking of using apply as a name but I'm still confused between apply and applymap as it's commonly used in other data science package (pandas ...).

I'll sleep on it. In any case, fmap_in_place is so descriptive that it won't be a problem to release it and eventually deprecate it.

@mratsim
Copy link
Owner

mratsim commented Sep 15, 2017

To stay consistent with Nim's sequtils can you rename fmap_in_place to apply?

Thanks.

@edubart
Copy link
Contributor Author

edubart commented Sep 15, 2017

Renamed to apply.

Copy link
Owner

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@mratsim mratsim merged commit ddbcc90 into mratsim:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants