Add bounds checks for fold and reduce axis inline operations #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try |
AngelEzquerra
force-pushed
the
foldreduce_axis_checks
branch
from
64d7434
to
aea5faa
Compare
Thank you. I have added the op to the reduce_axis_inline exception. I haven't added it to the fold_axis_inline one because there are 3 ops and I did not want to overcomplicate the exception message. |
Also fixes a small typo in ast_utils.nim.
AngelEzquerra
force-pushed
the
foldreduce_axis_checks
branch
from
aea5faa
to
2d3a50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors that you got when you tried to reduce or fold a tensor along a dimension that does not exist were pretty cryptic. Hopefully these will be an improvement.
It would be great if you could somehow refer to the "op" that is used for the reduction or the fold but I did not find a way to do it.
This PR also fixes an unrelated small typo in ast_utils.nim.