Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in nim-serialization is breaking the test suite #113

Closed
mratsim opened this issue Jan 20, 2021 · 1 comment
Closed

Regression in nim-serialization is breaking the test suite #113

mratsim opened this issue Jan 20, 2021 · 1 comment
Labels
testing 🛂 upstream 🐉

Comments

@mratsim
Copy link
Owner

mratsim commented Jan 20, 2021

See https://github.com/mratsim/constantine/runs/1679682880#step:16:1110

image

There is likely an ident refresh that is needed.
@mratsim mratsim mentioned this issue Jan 20, 2021
Open
mratsim added a commit that referenced this issue Jan 21, 2021
@mratsim
Pin nim-serialization. Workaround #113 and status-im/nim-serializatio…
ab3cf88 
…n#33
@mratsim mratsim mentioned this issue Jan 21, 2021
Merged
5 tasks
mratsim added a commit that referenced this issue Jan 21, 2021
@mratsim
Fix test suite (#116)
ac63005 
* Pin nim-serialization. Workaround #113 and status-im/nim-serialization#33

* Need to workaround nimble installing dependency multiple times

* non-interactive

* UB sanitizer missing on mingw

* Fix OpenSSL benchmark on non-Linux platforms

* Accelerate CI:
- Skip 32-bit on 64-bit tests
- Only test leaf functionality.

* Don't define -fstack-protector-all with MinGW

* skip line functions and cyclotomic tests (already tested in pairing) + only compile the benches don't run them.
@mratsim
Copy link
Owner Author

mratsim commented Jan 22, 2021

Closed by #116

@mratsim mratsim closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing 🛂 upstream 🐉
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mratsim