Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomized test failure sqrt mersenne127 #61

Closed
mratsim opened this issue Jun 20, 2020 · 0 comments · Fixed by #58
Closed

Randomized test failure sqrt mersenne127 #61

mratsim opened this issue Jun 20, 2020 · 0 comments · Fixed by #58
Labels
bug 🪲 Something isn't working has repro 🎯

Comments

@mratsim
Copy link
Owner

mratsim commented Jun 20, 2020

32-bit, seed 1592661951
commit 7c845ce
https://travis-ci.com/github/mratsim/constantine/jobs/351703535#L2039

image

This is probably detected via the new skewed RNG
@mratsim mratsim mentioned this issue Jun 20, 2020
Merged
3 tasks
@mratsim mratsim added the bug 🪲 Something isn't working label Jun 20, 2020
@mratsim mratsim mentioned this issue Jun 20, 2020
Closed
mratsim added a commit that referenced this issue Jun 21, 2020
@mratsim
Add #61 to the anti-regression suite
3a338f4
mratsim added a commit that referenced this issue Jun 21, 2020
@mratsim
For now deactivate montySquare CIOS fix #61 #62
2971965
This was referenced Jun 21, 2020
Closed
Merged
@mratsim mratsim linked a pull request Jun 22, 2020 that will close this issue
Fuzzing campaign fixes #58
Merged
2 tasks
mratsim added a commit that referenced this issue Jun 22, 2020
@mratsim
Fuzzing campaign fixes (#58)
ec76ac5 
* Add test case for #30 - Euler's criterion doesn't return 1 for a square

* Detect #42 in the test suite

* Detect #43 in the test suite

* comment in sqrt tests

* Add #67 to the anti-regression suite

* Add #61 to the anti-regression suite

* Add #62 to anti-regression suite

* Add #60 to the anti-regression suite

* Add #64 to the test suite

* Add #65 - case 1

* Add #65 case 2

* Add #65 case 3

* Add debug check to isSquare/Euler's Criterion/Legendre Symbol

* Make sure our primitives are correct

* For now deactivate montySquare CIOS fix #61 #62

* Narrow down #42 and #43 to powinv on 32-bit

* Detect #42 #43 at the fast squaring level

* More #42, #43 tests, Use multiplication instead of squaring as a temporary workaround, see #68

* Prevent regression of #67 now that squaring is "fixed"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working has repro 🎯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fuzzing campaign fixes mratsim/constantine
1 participant
@mratsim