Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use descriptive strings for reset sequences #7

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

mrazauskas
Copy link
Owner

Currently \u001b[0m and \u001b[39m sequences are replaced with </> in snapshots. The sequences are different, so I think this should be reflected in snapshots as well. Hence, this PR introduces descriptive strings for all supported reset sequences instead of </>.

For example, <dim><red>some</>text</> becomes <dim><red>some</color>text</> (assuming that first reset is \u001b[39m and second is \u001b[0m).

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #7 (02fb724) into main (1881a33) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           42        42           
  Branches         7         7           
=========================================
  Hits            42        42           
Impacted Files Coverage Δ
src/ansiEscapesSerializer.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1881a33...02fb724. Read the comment docs.

@mrazauskas mrazauskas merged commit 00db475 into main Jun 26, 2022
@mrazauskas mrazauskas deleted the refactor-reset-sequences branch June 26, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant