Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hana.tinyint type mapping to number. #37

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

kiko240
Copy link

@kiko240 kiko240 commented Jul 28, 2022

Hello,

In our project, we use type hana.tinyint, to create variables to be use together with annotation @common.FieldControl. This type was mapped into "unknown" by the package. So we changed it, and now it is map to "number".

For instance, we add "isStockVisible" variable of type hana.tinyint into Books:

image

As a result, initially we got this on the contract:

image

And, aftter adding the new mapping, the result we get is:

image

I hope it is usefull. If needed, make the corrections you consider.

Thanks in advandce!

Best regards,

Kiko

@kiko240 kiko240 marked this pull request as ready for review July 28, 2022 00:08
@HeneryHawk
Copy link
Collaborator

Hi @kiko240,

thanks for your contribution. I will merge this PR and create a new version the next days.

Regards
Simon

@HeneryHawk HeneryHawk merged commit 9ca4aaf into mrbandler:master Jul 29, 2022
@HeneryHawk
Copy link
Collaborator

Hi @kiko240,

release v2.8.0 was published. Thanks again for your collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants