Combined cleaninfo+waterinfo

[dbochicchio]

Hey @mrbungle64 I've added a new event to combine cleaning status with waterinfo. This makes easier in my MQTT bridge to get the real status (ie: mopping or cleaning) in a central and unique place.

[mrbungle64]

TODO: Implement method for duplicate code

[mrbungle64]

Hey @mrbungle64 I've added a new event to combine cleaning status with waterinfo. This makes easier in my MQTT bridge to get the real status (ie: mopping or cleaning) in a central and unique place.

Hi @dbochicchio

I thinkk we have to rename the "CleanReportDetails" event because some models don't have a mopping system.

Which name do you prefer?

• CleanReportWaterbox
• CleanReportWaterInfo
• CleanReportWaterboxInfo

[mrbungle64]

@dbochicchio

Do we still need the "Waterinfo" event? I think we can remove it ...

this.emit("WaterInfo", {
    'enabled': this.bot.waterboxInfo,
    'level': this.bot.waterLevel
});

[mrbungle64]

@dbochicchio

I also would like to convert waterboxInfo (enabled attribute) to boolean:

{
  "status": "idle",
  "waterInfo": {
    "enabled": false,
    "level": 4
  }
}

[mrbungle64]

@dbochicchio

I want to use the event name MoppingSystemInfo and rename the status attribute to cleanStatus (see commit 60aeab5)
I think it represents that better.

{
  "cleanStatus": "idle",
  "waterInfo": {
    "enabled": false,
    "level": 4
  }
}

emitMoppingSystemReport() {
    if (this.bot.hasMoppingSystem() && this.bot.waterLevel && (this.bot.waterboxInfo !== null)) {
        this.emit("MoppingSystemInfo", {
            'cleanStatus': this.bot.cleanReport,
            'waterInfo': {
                'enabled': Boolean(Number(this.bot.waterboxInfo)),
                'level': this.bot.waterLevel
            }
        });
    }
}

[dbochicchio]

@mrbungle64 it's ok for me. I'm using this event to understand when it's starting and if it's mopping or just cleaning, by looking at enabled. You're the maintainer, so it's up to you, I'm good with anything you'll pick ;)