Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try more wmic /format:CSV options to get Windows mount points #52

Merged
merged 3 commits into from
Apr 6, 2018

Conversation

weshinsley
Copy link
Contributor

@weshinsley weshinsley commented Apr 6, 2018

This PR addresses the following warning (and subsequent issues), occuring when we fail to get a CSV of windows mount points:-

didehpc::didehpc_config()
Error in read.table(file = file, header = header, sep = sep, quote = quote, :
no lines available in input
In addition: Warning message:
running command '"wmic" netuse list brief /format:"C:\WINDOWS\System32\wbem\en-US\csv"' had status 44210

Windows is picky (and inconsistent across machines) about what format it wants. The solution is to try each of these in turn until a successful result is obtained.

/format:"[windir]\System32\wbem\en-US\csv"
/format:"[windir]\System32\wbem\en-GB\csv"
/format:"csv"

as an argument for
wmic netuse list brief /format:

@weshinsley weshinsley requested a review from richfitz April 6, 2018 14:28
@richfitz
Copy link
Member

richfitz commented Apr 6, 2018

Can you please bump the version number to 0.1.6 and add an entry to the NEWS?

@weshinsley
Copy link
Contributor Author

Version number and NEWS updated!

@richfitz richfitz merged commit 9136789 into master Apr 6, 2018
@richfitz
Copy link
Member

richfitz commented Apr 6, 2018

thanks! on the mrc-ide drat now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants