Allow setting state with index #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exists already in mode and is actually very useful, even though we've removed the need for it in mode (this existed to support setting the stochasic variables before we implemented direct stochasic simulation). Getting this working on the GPU is a bit of a faff and I'm feeling we might defer that until after the merge is complete because there will likely be a few other GPU tweaks. The use case for this soon is to support zeroing some variables periodically, so that we can turn cumulative measurements into daily measurements, as pomp does. But also just to smooth over the difference with mode of course.
Codecov ReportBase: 99.83% // Head: 99.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 99.83% 99.74% -0.09%
==========================================
Files 68 68
Lines 3547 3564 +17
==========================================
+ Hits 3541 3555 +14
- Misses 6 9 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hillalex
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exists already in mode and is actually very useful, even though we've removed the need for it in mode (this existed to support setting the stochasic variables before we implemented direct stochasic simulation). Getting this working on the GPU is a bit of a faff and I'm feeling we might defer that until after the merge is complete because there will likely be a few other GPU tweaks.
The use case for this soon is to support zeroing some variables periodically, so that we can turn cumulative measurements into daily measurements, as pomp does. But also just to smooth over the difference with mode of course.