Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA score assignment #47

Merged
merged 62 commits into from
May 28, 2024
Merged

QA score assignment #47

merged 62 commits into from
May 28, 2024

Conversation

sangeetabhatia03
Copy link
Collaborator

This PR adds a function to add QA score to articles as the number of questions answered with a yes divided by the number of non-NA answers. PR adds tests and bumps up version number.

sangeetabhatia03 and others added 11 commits April 12, 2024 12:13
- Living reviews will now be hosted on the priority-pathogens GH Pages
  website
- Adds links for Marburg and Lassa
- This change fixes broken links and adds missing source code repo link
  on GH Pages website
- Also loads epireview rather than sourcing the R-Script
- Moves imports to standalone setup block
cm401 and others added 18 commits April 29, 2024 16:51
- Living reviews will now be hosted on the priority-pathogens GH Pages
  website
- Adds links for Marburg and Lassa
- This change fixes broken links and adds missing source code repo link
  on GH Pages website
- Also loads epireview rather than sourcing the R-Script
- Moves imports to standalone setup block
- Describes what information is required and includes a checklist
Update column name in tests

reorder_studies previously returned a column called y. This behaviour was later changed (forest plots use article labels as the y-axis and there was no need to add another column).
But the test had not been updated and was still using y. I have now fixed this.
Copy link
Collaborator

@cm401 cm401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank, this looks good and works for me for QA and articles data (which resolves the associated issue).

However we still have issue #56 which this doesn't fix. Maybe best to get this merged in and work on issue #56 separately.

Thank you!

@sangeetabhatia03
Copy link
Collaborator Author

Thanks, I am working on #56 and will raise a separate PR for it.

@cm401
Copy link
Collaborator

cm401 commented May 28, 2024

Thanks, I am working on #56 and will raise a separate PR for it.

Amazing - thank you!!!

@sangeetabhatia03 sangeetabhatia03 merged commit f7c8a03 into develop May 28, 2024
@sangeetabhatia03 sangeetabhatia03 deleted the add-qa branch May 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all required data to articles data frame from load_epidata
5 participants