Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrc 523 Quarter filter for Programme and ANC #88

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Mrc 523 Quarter filter for Programme and ANC #88

merged 5 commits into from
Oct 10, 2019

Conversation

EmmaLRussell
Copy link
Contributor

@EmmaLRussell EmmaLRussell commented Oct 9, 2019

This looks a little odd when first load survey data, as there is no selected quarter filter, and no available quarter values. I'm going to address improving the look of disabled filters in mrc-552

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #88 into master will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #88    +/-   ##
========================================
+ Coverage        97%    97%   +<1%     
  Complexity       95     95            
========================================
  Files            88     88            
  Lines          1431   1446    +15     
  Branches        208    212     +4     
========================================
+ Hits           1399   1414    +15     
  Misses           26     26            
  Partials          6      6
Impacted Files Coverage Δ Complexity Δ
.../static/src/app/store/filteredData/filteredData.ts 100% <100%> (ø) 0 <0> (ø) ⬇️
...pp/static/src/app/components/ChoroplethFilters.vue 97% <100%> (ø) 0 <0> (ø) ⬇️
...app/static/src/app/store/filteredData/mutations.ts 100% <100%> (ø) 0 <0> (ø) ⬇️
...c/app/static/src/app/store/filteredData/getters.ts 96% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765e038...a0453c3. Read the comment docs.

@hillalex hillalex merged commit a4febb8 into master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants