Add test for generating input time series plot when no vls data present #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 27 27
Lines 1771 1771
=======================================
Hits 1738 1738
Misses 33 33 Continue to review full report at Codecov.
|
r-ash
changed the title
hillalex
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing previously but has been fixed in Naomi. This should fix the build problems you were having this morning. The problem was we merged the #310 in which the input time series was assuming that the data would have new VLS columns. The test data in hint doesn't have those new columns but the columns are optional so it should work with or without them.