Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CRAN, following change of behaviour of is.atomic(NULL) #306

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Oct 2, 2023

This PR fixes the breaking change coming from R:

r85227 | maechler | 2023-09-28 09:38:16 +0200 (Thu, 28 Sep 2023) | 1 line
is.atomic(NULL) now is FALSE

Please see
https://stat.ethz.ch/pipermail/r-devel/2023-September/082892.html for
more information and guidance.

Please correct before 2023-10-14 to safely retain your package on CRAN.

which is producing errors like

     ══ Failed tests ════════════════════════════════════════════════════════════════
     ── Error ('test-interface.R:19:3'): n_history is configurable ──────────────────
     Error in `ir_serialise_expression(eq$delay$default)`: unhandled expression [odin bug]
     Backtrace:
     ▆
     1. └─odin::odin(...) at test-interface.R:19:2
     2. └─odin::odin_(...)
     3. └─odin::odin_parse_(x, options)
     4. └─odin:::ir_parse(x, options, type)
     5. └─odin:::ir_serialise(ret, options$pretty)
     6. └─odin:::ir_serialise_equations(dat$equations)
     7. └─base::lapply(unname(equations), ir_serialise_equation)
     8. └─odin (local) FUN(X[[i]], ...)
     9. └─odin:::ir_serialise_delay_continuous(eq)
     10. └─odin:::ir_serialise_expression(eq$delay$default)

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
R/ir_serialise.R 99.35% <50.00%> (-0.65%) ⬇️

📢 Thoughts on this report? Let us know!.

@richfitz richfitz marked this pull request as ready for review October 2, 2023 11:05
@richfitz richfitz merged commit c51efee into master Oct 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant