Update outpack schema file. (#50)

The new schema file adds requirements on the characters used by paths
found in the metadata. This aims at ensuring cross-platform
compatibility.

src/outpack/schema/outpack/README.md

@@ -1,8 +1,8 @@
 # Imported from outpack
 
 * Schema version 0.1.1
-* Imported on 2023-12-04 11:53:24.971506
-* From outpack @ 61bd5d84b0c737d3fb7dd24d45e4a117cd4e8bb5 (main)
+* Imported on 2024-05-10 14:22:08.807105
+* From outpack @ 5350c1766d95d1ef707552ed3275ed625a419e0c (main)
 
 Do not make changes to files here, they will be overwritten
 Run ./scripts/update_schemas to update

src/outpack/schema/outpack/metadata.json

@@ -60,7 +60,7 @@
                 "properties": {
                     "path": {
                         "description": "The path of the file",
-                        "type": "string"
+                        "$ref": "relative-path.json"
                     },
                     "hash": {
                         "$ref": "hash.json"
@@ -93,11 +93,11 @@
                             "properties": {
                                 "here": {
                                     "description": "The path of the file in this packet",
-                                    "type": "string"
+                                    "$ref": "relative-path.json"
                                 },
                                 "there": {
                                     "description": "The path of the file within the upstream packet",
-                                    "type": "string"
+                                    "$ref": "relative-path.json"
                                 }
                             },
                             "required": ["here", "there"]

src/outpack/schema/outpack/relative-path.json

@@ -0,0 +1,9 @@
+{
+    "$schema": "http://json-schema.org/draft-07/schema#",
+    "title": "File path",
+    "description": "A relative cross-platform file path",
+    "version": "0.1.1",
+
+    "type": "string",
+    "pattern": "^([^<>:\"/\\\\|?*\\x00-\\x1f]+/)*[^<>:\"/\\\\|?*\\x00-\\x1f]+$"
+}

tests/test_packet.py

@@ -1,4 +1,7 @@
+import os
+
 import pytest
+from jsonschema.exceptions import ValidationError
 
 from outpack.init import outpack_init
 from outpack.metadata import PacketDependsPath
@@ -273,3 +276,26 @@ def test_can_search_with_this_parameter(tmp_path):
     with create_packet(root, "downstream", parameters={"x": 2}) as p:
         result = p.use_dependency(query)
         assert result.id == id2
+
+
+@pytest.mark.skipif(
+    os.name == "nt",
+    reason="This test uses filenames that aren't valid on Windows",
+)
+def test_cannot_create_packet_with_invalid_filename(tmp_path):
+    root = create_temporary_root(tmp_path)
+
+    # These are legal filenames on POSIX, but not on Windows. If we allowed
+    # these in packets we would not be able to pull the packets on a Windows
+    # machine.
+    with pytest.raises(ValidationError):
+        with create_packet(root, "data") as p:
+            (p.path / R"bad\file\name").touch()
+
+    with pytest.raises(ValidationError):
+        with create_packet(root, "data") as p:
+            (p.path / "bad<file>name").touch()
+
+    with pytest.raises(ValidationError):
+        with create_packet(root, "data") as p:
+            (p.path / "bad\x01file\x01name").touch()