Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths in packet metadata. #46

Merged
merged 1 commit into from
May 3, 2024
Merged

Normalize paths in packet metadata. #46

merged 1 commit into from
May 3, 2024

Commits on May 3, 2024

  1. Normalize paths in packet metadata.

    The packet metadata keeps a record of what files are used and/or
    produced by the report. When such files are directories, we want to
    normalize the path separator. This will ensure that a packet produced on
    Windows can be used on POSIX platforms and vice-versa.
    
    Additionally, R (and therefore orderly2) uses forward slashes on all
    platforms, including Windows. Using forward slashes in outpack-py means
    packets are compatible and consistent across the two tools.
    
    It's not obvious whether the functions that return copied paths to the
    caller (eg. `orderly.shared_resource`) should return native paths or
    POSIX paths. For now I've kept these as native paths.
    plietar committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a588593 View commit details
    Browse the repository at this point in the history