Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orderly db metadata #14

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Add orderly db metadata #14

merged 6 commits into from
Feb 5, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Feb 2, 2024

This PR migrates orderly db metadata from existing packets.

Also includes a test that shows that if we run orderly1 and migrate we get the same (effective) metadata as running migrate on the source then orderly2

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8cb4cd) 100.00% compared to head (6742db9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          325       368   +43     
=========================================
+ Hits           325       368   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review February 2, 2024 11:55
@richfitz richfitz requested a review from r-ash February 2, 2024 11:56
Copy link
Contributor

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@@ -0,0 +1,59 @@
test_that("migrating source then archive is same as archive then source", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@r-ash r-ash merged commit 653e5fa into main Feb 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants