Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating of migrated outpack archives #2

Merged
merged 7 commits into from Nov 2, 2022
Merged

Allow updating of migrated outpack archives #2

merged 7 commits into from Nov 2, 2022

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 1, 2022

This makes two changes to allow updating of a migrated orderly archive:

  • use a link-based file store; this means that we don't require two full copies of the data always (which would be problematic on montagu)
  • allow the destination to exist, so long as it looks like something we could migrate into

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1e0a2b2) compared to base (79a012f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1e0a2b2 differs from pull request most recent head ea62184. Consider uploading reports for the commit ea62184 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines          113       129   +16     
=========================================
+ Hits           113       129   +16     
Impacted Files Coverage Δ
R/migrate.R 100.00% <100.00%> (ø)
R/store.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richfitz richfitz changed the title Allow updating of file stores Allow updating of migrated outpack archives Nov 1, 2022
@richfitz richfitz marked this pull request as ready for review November 1, 2022 10:57
@richfitz richfitz merged commit cc28f0e into main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants