-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrc-4177 allow passing of dependencies to task queue #31
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 503 504 +1
=========================================
+ Hits 503 504 +1
☔ View full report in Codecov by Sentry. |
R/queue_base.R
Outdated
@@ -250,7 +250,9 @@ queue_base <- R6::R6Class( | |||
##' | |||
##' @param name Optional name for a created bundle | |||
##' | |||
##' @param depends_on Optional vector of task ids to depend on | |||
##' @param depends_on Optional task ids to depend on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that roxygen2 can do @inheritParams
from a different package so you can do @inheritParams context::bulk_task_save
here and delete this specific docs and then you'd not need to duplicate the text? Not 100%, give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that doesn't work inside R6 classes which support a more limited set of tags. I've updated to link to the context
docs though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry, of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the branch pointer to revert
Co-authored-by: Rich FitzJohn <rich.fitzjohn@gmail.com>
Allows single or bulk enqueuing to accept a vector or list of task ids to depend on. Requires mrc-ide/context#21