Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-4177 allow passing of dependencies to task queue #31

Merged
merged 12 commits into from
May 25, 2023
Merged

Conversation

hillalex
Copy link
Contributor

@hillalex hillalex commented Apr 24, 2023

Allows single or bulk enqueuing to accept a vector or list of task ids to depend on. Requires mrc-ide/context#21

@hillalex hillalex changed the title Mrc 4177 mrc-4177 allow passing of dependencies to task queue Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f3ff274) 100.00% compared to head (bef9f0d) 100.00%.

❗ Current head bef9f0d differs from pull request most recent head df2e4ab. Consider uploading reports for the commit df2e4ab to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          503       504    +1     
=========================================
+ Hits           503       504    +1     
Impacted Files Coverage Δ
R/queue_local.R 100.00% <ø> (ø)
R/bulk.R 100.00% <100.00%> (ø)
R/queue_base.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hillalex hillalex marked this pull request as ready for review May 4, 2023 20:26
R/queue_base.R Outdated
@@ -250,7 +250,9 @@ queue_base <- R6::R6Class(
##'
##' @param name Optional name for a created bundle
##'
##' @param depends_on Optional vector of task ids to depend on
##' @param depends_on Optional task ids to depend on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that roxygen2 can do @inheritParams from a different package so you can do @inheritParams context::bulk_task_save here and delete this specific docs and then you'd not need to duplicate the text? Not 100%, give it a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that doesn't work inside R6 classes which support a more limited set of tags. I've updated to link to the context docs though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry, of course

Copy link
Member

@richfitz richfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the branch pointer to revert

DESCRIPTION Outdated Show resolved Hide resolved
Co-authored-by: Rich FitzJohn <rich.fitzjohn@gmail.com>
@hillalex hillalex merged commit 41cf782 into master May 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants