Refactor Tock to an OO implementation

[ydaniv]

This refactor fixes misuse of this inside _tick() which contaminated global namespace.

This implementation is much more memory efficient since it's not redefining the inner functions of Tock on every instance generation. Instead they reuse all the module's private functions via closure and Tock's public methods on its prototype.

Note that everything should remain the same, except for passing reference to a method of a Tock's instance. This should be done with care since state is now managed in an OO way via this.

[ydaniv]

@mrchimp should I resolve these conflicts? Are you even considering this PR?

BTW, I've found bugs in the tick mechanism and fixed it for the regular Tock, i.e. not countdown.
If this PR is of any interest I can also fix it for countdown mode and send updates on this PR.

[mrchimp]

Hi Yehonatan

Sorry, been busy over the holidays. Back to work today. Definitely
considering merging this. If you could resolve the conflicts and update the
PR that would be ideal.

Cheers!

On 5 January 2015 at 08:35, Yehonatan Daniv notifications@github.com
wrote:

@mrchimp https://github.com/mrchimp should I resolve these conflicts?
Are you even considering this PR?

BTW, I've found bugs in the tick mechanism and fixed it for the regular
Tock, i.e. not countdown.
If this PR is of any interest I can also fix it for countdown mode and
send updates on this PR.

—
Reply to this email directly or view it on GitHub
#21 (comment).

[ydaniv]

Sure thing 👍

[ydaniv]

Closing, see resolved and updated PR #22